Skip to content

history: support single row context menu #1482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 11, 2025

Conversation

shakyShane
Copy link
Contributor

@shakyShane shakyShane commented Feb 11, 2025

Asana Task/Github Issue: https://app.asana.com/0/1201141132935289/1209375474836154

Description

  • added context menu + 3 buttons click on individual rows

Testing Steps

  • cd special-pages && npm run watch -- --page=history
  • visit http://localhost:8000?history=4000
  • on a row-level, click the 3 dots, or right click the row
  • confirm the deletion, the item should be removed
image

Checklist

Please tick all that apply:

  • I have tested this change locally
  • I have tested this change locally in all supported browsers
  • This change will be visible to users
  • I have added automated tests that cover this change
  • I have ensured the change is gated by config
  • This change was covered by a ship review
  • This change was covered by a tech design
  • Any dependent config has been merged

@shakyShane
Copy link
Contributor Author

shakyShane commented Feb 11, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

github-actions bot commented Feb 11, 2025

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

@shakyShane shakyShane marked this pull request as ready for review February 11, 2025 16:15
@shakyShane shakyShane requested review from mgurgel and a team as code owners February 11, 2025 16:15
Copy link

github-actions bot commented Feb 11, 2025

[Beta] Generated file diff

Time updated: Tue, 11 Feb 2025 20:23:59 GMT

Integration
    - integration/pages/history/dist/index.js

File has changed

Windows
    - windows/pages/history/dist/index.js

File has changed

Apple
    - dist/pages/history/dist/index.js

File has changed

@shakyShane shakyShane assigned shakyShane and mgurgel and unassigned shakyShane Feb 11, 2025
@shakyShane shakyShane force-pushed the 02-11-history_support_single_row_context_menu branch 4 times, most recently from 9a2ea3e to e2d1fd7 Compare February 11, 2025 17:28
mgurgel
mgurgel previously approved these changes Feb 11, 2025
Base automatically changed from 02-11-history_context_menu_for_section_titles to main February 11, 2025 20:20
@shakyShane shakyShane dismissed mgurgel’s stale review February 11, 2025 20:20

The base branch was changed.

@shakyShane shakyShane force-pushed the 02-11-history_support_single_row_context_menu branch from e2d1fd7 to 745bfc7 Compare February 11, 2025 20:23
Copy link

netlify bot commented Feb 11, 2025

Deploy Preview for content-scope-scripts ready!

Name Link
🔨 Latest commit 745bfc7
🔍 Latest deploy log https://app.netlify.com/sites/content-scope-scripts/deploys/67abb1a5da2cb4000890077b
😎 Deploy Preview https://deploy-preview-1482--content-scope-scripts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@shakyShane shakyShane merged commit a07216a into main Feb 11, 2025
12 checks passed
@shakyShane shakyShane deleted the 02-11-history_support_single_row_context_menu branch February 11, 2025 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants