Skip to content

ntp: new show/hide buttons #1491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 24, 2025
Merged

ntp: new show/hide buttons #1491

merged 5 commits into from
Feb 24, 2025

Conversation

shakyShane
Copy link
Contributor

@shakyShane shakyShane commented Feb 16, 2025

Asana Task/Github Issue: https://app.asana.com/0/1201141132935289/1209397618090557

Description

  • added 'Show more' | 'Show less' text to the button on expander sections

Testing Steps

Checklist

Please tick all that apply:

  • I have tested this change locally
  • I have tested this change locally in all supported browsers
  • This change will be visible to users
  • I have added automated tests that cover this change
  • I have ensured the change is gated by config
  • This change was covered by a ship review
  • This change was covered by a tech design
  • Any dependent config has been merged

@shakyShane shakyShane marked this pull request as ready for review February 16, 2025 10:31
@shakyShane shakyShane requested review from mgurgel and a team as code owners February 16, 2025 10:31
@shakyShane
Copy link
Contributor Author

shakyShane commented Feb 16, 2025

Copy link

github-actions bot commented Feb 16, 2025

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

Copy link

netlify bot commented Feb 16, 2025

Deploy Preview for content-scope-scripts ready!

Name Link
🔨 Latest commit 37fe219
🔍 Latest deploy log https://app.netlify.com/sites/content-scope-scripts/deploys/67bc7dddde7d260008dff47a
😎 Deploy Preview https://deploy-preview-1491--content-scope-scripts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Feb 16, 2025

[Beta] Generated file diff

Time updated: Mon, 24 Feb 2025 14:11:34 GMT

Integration
    - integration/pages/new-tab/dist/index.css
  • integration/pages/new-tab/dist/index.js

File has changed

Windows
    - windows/pages/new-tab/dist/index.css
  • windows/pages/new-tab/dist/index.js

File has changed

Apple
    - dist/pages/new-tab/dist/index.css
  • dist/pages/new-tab/dist/index.js

File has changed

mgurgel
mgurgel previously approved these changes Feb 20, 2025
Copy link
Contributor

@mgurgel mgurgel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Previews work as described.

@shakyShane shakyShane force-pushed the 02-16-ntp_new_show_hide_buttons branch 2 times, most recently from 7167255 to 4b09392 Compare February 23, 2025 21:43
@shakyShane shakyShane changed the base branch from main to shane/ntp-favorites-update February 23, 2025 21:43
Base automatically changed from shane/ntp-favorites-update to main February 24, 2025 11:25
@shakyShane shakyShane force-pushed the 02-16-ntp_new_show_hide_buttons branch from b2c9e63 to 3460850 Compare February 24, 2025 11:29
@shakyShane shakyShane merged commit 79aaee5 into main Feb 24, 2025
12 checks passed
@shakyShane shakyShane deleted the 02-16-ntp_new_show_hide_buttons branch February 24, 2025 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants