Skip to content

ntp: expanded favorites widget can accept large updates in place #1501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 24, 2025

Conversation

shakyShane
Copy link
Contributor

@shakyShane shakyShane commented Feb 23, 2025

Asana Task/Github Issue: https://app.asana.com/0/1201141132935289/1209466327106094

Description

When the favorites widget was already expanded, updating to a larger dataset (like when importing favorites) would cause a resize observer to trigger, at which point it was referencing a callback with an incorrectly captured length of rows.

  • the fix is to ensure we invalidate the callbacks/events when the row length changes.

Testing Steps

  • it's tricky to reproduce, see the update integration test for an example though.

Checklist

Please tick all that apply:

  • I have tested this change locally
  • I have tested this change locally in all supported browsers
  • This change will be visible to users
  • I have added automated tests that cover this change
  • I have ensured the change is gated by config
  • This change was covered by a ship review
  • This change was covered by a tech design
  • Any dependent config has been merged

@shakyShane
Copy link
Contributor Author

shakyShane commented Feb 23, 2025

Copy link

netlify bot commented Feb 23, 2025

Deploy Preview for content-scope-scripts ready!

Name Link
🔨 Latest commit 183f863
🔍 Latest deploy log https://app.netlify.com/sites/content-scope-scripts/deploys/67bb953e584c290008cc8dba
😎 Deploy Preview https://deploy-preview-1501--content-scope-scripts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Feb 23, 2025

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

Copy link

github-actions bot commented Feb 23, 2025

[Beta] Generated file diff

Time updated: Sun, 23 Feb 2025 21:42:26 GMT

Integration
    - integration/pages/new-tab/dist/index.js

File has changed

Windows
    - windows/pages/new-tab/dist/index.js

File has changed

Apple
    - dist/pages/new-tab/dist/index.js

File has changed

@shakyShane shakyShane marked this pull request as ready for review February 23, 2025 21:41
@shakyShane shakyShane requested review from mgurgel and a team as code owners February 23, 2025 21:41
@shakyShane shakyShane mentioned this pull request Feb 23, 2025
9 tasks
@shakyShane shakyShane merged commit 129d82f into main Feb 24, 2025
19 checks passed
@shakyShane shakyShane deleted the shane/ntp-favorites-update branch February 24, 2025 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants