Skip to content

history: ship review changes #1522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 3, 2025
Merged

history: ship review changes #1522

merged 1 commit into from
Mar 3, 2025

Conversation

shakyShane
Copy link
Contributor

@shakyShane shakyShane commented Feb 27, 2025

Asana Task/Github Issue: https://app.asana.com/0/1201141132935289/1209526509978633

Description

  • multiple selections + click on three dots should impact all selected
  • some styling parts for a reduced width layout
  • support clicking outside of rows to de-select
  • added unit-tests for the selection logic too, since it's complicated enough already

Testing Steps

Checklist

Please tick all that apply:

  • I have tested this change locally
  • I have tested this change locally in all supported browsers
  • This change will be visible to users
  • I have added automated tests that cover this change
  • I have ensured the change is gated by config
  • This change was covered by a ship review
  • This change was covered by a tech design
  • Any dependent config has been merged

Copy link

netlify bot commented Feb 27, 2025

Deploy Preview for content-scope-scripts ready!

Name Link
🔨 Latest commit 3c9f8bf
🔍 Latest deploy log https://app.netlify.com/sites/content-scope-scripts/deploys/67c58307b35b1a000843b4cc
😎 Deploy Preview https://deploy-preview-1522--content-scope-scripts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@shakyShane
Copy link
Contributor Author

shakyShane commented Feb 27, 2025

Copy link

github-actions bot commented Feb 27, 2025

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

Copy link

github-actions bot commented Feb 27, 2025

[Beta] Generated file diff

Time updated: Mon, 03 Mar 2025 10:23:59 GMT

Integration
    - integration/pages/history/dist/index.css
  • integration/pages/history/dist/index.js
  • integration/pages/history/locales/en/history.json

File has changed

Windows
    - windows/pages/history/dist/index.css
  • windows/pages/history/dist/index.js
  • windows/pages/history/locales/en/history.json

File has changed

Apple
    - dist/pages/history/dist/index.css
  • dist/pages/history/dist/index.js
  • dist/pages/history/locales/en/history.json

File has changed

@shakyShane shakyShane marked this pull request as ready for review February 27, 2025 16:29
@shakyShane shakyShane requested review from mgurgel and a team as code owners February 27, 2025 16:29
@shakyShane shakyShane mentioned this pull request Feb 28, 2025
9 tasks
@shakyShane shakyShane changed the base branch from main to 03-03-node_22 March 3, 2025 10:02
@shakyShane shakyShane force-pushed the shane/history-sr branch 2 times, most recently from 890d241 to eadf558 Compare March 3, 2025 10:05
Base automatically changed from 03-03-node_22 to main March 3, 2025 10:18
Copy link
Contributor

@mgurgel mgurgel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@shakyShane shakyShane merged commit f8898f5 into main Mar 3, 2025
15 checks passed
@shakyShane shakyShane deleted the shane/history-sr branch March 3, 2025 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants