Skip to content

injected: replace rollup with esbuild #1521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 17, 2025
Merged

injected: replace rollup with esbuild #1521

merged 5 commits into from
Mar 17, 2025

Conversation

shakyShane
Copy link
Contributor

@shakyShane shakyShane commented Feb 27, 2025 •
edited
Loading

Asana Task/Github Issue: https://app.asana.com/0/1201141132935289/1204895631127021

Description

  • use esbuild for the injected entry points
  • remove the notion of building a single platform, just build everything everytime instead

Testing Steps

  • apple
  • android
  • chrome
  • firefox
  • windows

Checklist

Please tick all that apply:

  • I have tested this change locally
  • I have tested this change locally in all supported browsers
  • This change will be visible to users
  • I have added automated tests that cover this change
  • I have ensured the change is gated by config
  • This change was covered by a ship review
  • This change was covered by a tech design
  • Any dependent config has been merged

@shakyShane shakyShane requested review from mgurgel, a team, kzar and sammacbeth as code owners February 27, 2025 08:50
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 27, 2025 •
edited
Loading

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

@netlify Netlify
Copy link

netlify bot commented Feb 27, 2025 •
edited
Loading

✅ Deploy Preview for content-scope-scripts ready!

Name Link
🔨 Latest commit 496bdba
🔍 Latest deploy log https://app.netlify.com/sites/content-scope-scripts/deploys/67d848e87d96b2000808ac89
😎 Deploy Preview https://deploy-preview-1521--content-scope-scripts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 27, 2025 •
edited
Loading

[Beta] Generated file diff

Time updated: Mon, 17 Mar 2025 16:07:43 GMT

Android 
    - android/autofillPasswordImport.js
  • android/brokerProtection.js
  • android/contentScope.js

File has changed

Removed Files 
    - chrome/inject.js

❌ File only exists in old changeset

Chrome-mv3 
    - chrome-mv3/inject.js

File has changed

Firefox 
    - firefox/inject.js

File has changed

Integration 
    - integration/contentScope.js

File has changed

Windows 
    - windows/contentScope.js

File has changed

Apple 
    - dist/contentScope.js
  • dist/contentScopeIsolated.js

File has changed

@shakyShane shakyShane force-pushed the shane/inject-esbuild branch from 8d84d5b to f42f3ce Compare March 3, 2025 10:09
@shakyShane shakyShane changed the base branch from main to 03-03-node_22 March 3, 2025 10:09
@shakyShane
Copy link
Contributor Author

shakyShane commented Mar 3, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Mar 3, 2025
Merged
Merged
Merged
Merged
Base automatically changed from 03-03-node_22 to main March 3, 2025 10:18
@shakyShane shakyShane force-pushed the shane/inject-esbuild branch 2 times, most recently from f411070 to 25b8b74 Compare March 3, 2025 12:01
@shakyShane shakyShane force-pushed the shane/inject-esbuild branch from 218407b to 087a0cf Compare March 3, 2025 20:19
jonathanKingston
jonathanKingston reviewed Mar 11, 2025
View reviewed changes
jonathanKingston
jonathanKingston reviewed Mar 11, 2025
View reviewed changes
jonathanKingston
jonathanKingston reviewed Mar 11, 2025
View reviewed changes
@shakyShane shakyShane force-pushed the shane/inject-esbuild branch 2 times, most recently from 86f54d0 to e4e755c Compare March 13, 2025 08:43
@shakyShane shakyShane changed the base branch from main to graphite-base/1521 March 13, 2025 08:49
@shakyShane shakyShane force-pushed the shane/inject-esbuild branch from e4e755c to bc043c0 Compare March 13, 2025 08:49
@shakyShane shakyShane changed the base branch from graphite-base/1521 to dbajpeyi/refactor/decouple-import-meta March 13, 2025 08:49
@shakyShane shakyShane mentioned this pull request Mar 13, 2025
Merged
8 tasks
Base automatically changed from dbajpeyi/refactor/decouple-import-meta to main March 13, 2025 09:44
@jonathanKingston jonathanKingston requested a review from a team as a code owner March 13, 2025 09:44
@jonathanKingston jonathanKingston requested a review from a team as a code owner March 13, 2025 09:44
@shakyShane shakyShane force-pushed the shane/inject-esbuild branch from bc043c0 to 0012155 Compare March 13, 2025 09:51
jonathanKingston
jonathanKingston reviewed Mar 13, 2025
View reviewed changes
@shakyShane shakyShane mentioned this pull request Mar 15, 2025
Merged
9 tasks
@shakyShane
poc: preserve comments in esbuild (#1565)
232942e 
* poc: preserve comments in esbuild

* comment

* more test cases

* more test cases
@shakyShane
additional test
496bdba
@jonathanKingston jonathanKingston merged commit 2f1ce09 into main Mar 17, 2025
13 checks passed
@jonathanKingston jonathanKingston deleted the shane/inject-esbuild branch March 17, 2025 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathanKingston jonathanKingston jonathanKingston approved these changes

@mgurgel mgurgel Awaiting requested review from mgurgel mgurgel is a code owner

@kzar kzar Awaiting requested review from kzar

@sammacbeth sammacbeth Awaiting requested review from sammacbeth

Assignees

@jonathanKingston jonathanKingston

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shakyShane @jonathanKingston