[ContentFeature] de-decouple build specific code from content-features

[dbajpeyi]

Asana Task/Github Issue: https://app.asana.com/0/72649045549333/1209507178584805

Description

1. Move out feature setting parsing logic to a ConfigFeature class, which allows outside packages to re-use functionality like getFeatureSetting, without having to implement the whole ContentFeature
2. Move out all import.meta code from the core code, and pass it as importConfig in the content-scope-features.js class

Testing Steps

Checklist

Please tick all that apply:

• I have tested this change locally
• I have tested this change locally in all supported browsers
• This change will be visible to users
• I have added automated tests that cover this change
• I have ensured the change is gated by config
• This change was covered by a ship review
• This change was covered by a tech design
• Any dependent config has been merged

[netlify]

✅ Deploy Preview for content-scope-scripts ready!

Name	Link
🔨 Latest commit	c3d8d69
🔍 Latest deploy log	https://app.netlify.com/sites/content-scope-scripts/deploys/67d297051b095e00085434d8
😎 Deploy Preview	https://deploy-preview-1545--content-scope-scripts.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[github-actions]

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

• Branch Name: pr-releases/pr-1545
• Commit Hash: d36d17d80a1bdc4603a724c1f643e0f6fd7ebb22
• Install Command: npm i github:duckduckgo/content-scope-scripts#d36d17d80a1bdc4603a724c1f643e0f6fd7ebb22

Please use the above install command to update to the latest version.

[github-actions]

[Beta] Generated file diff

Time updated: Thu, 13 Mar 2025 08:28:45 GMT

Android

    - android/autofillPasswordImport.js

• android/brokerProtection.js
• android/contentScope.js

File has changed

Chrome

    - chrome/inject.js

File has changed

Chrome-mv3

    - chrome-mv3/inject.js

File has changed

Firefox

    - firefox/inject.js

File has changed

Integration

    - integration/contentScope.js

File has changed

Windows

    - windows/contentScope.js

File has changed

Apple

    - dist/contentScope.js

• dist/contentScopeIsolated.js

File has changed

[jonathanKingston]

Suggested change

	this.args = null;
	this.#args = null;

[dbajpeyi]

@jonathanKingston I've addressed the comments. Note that the references are this.args are unique now, because the base class has a setter. Please let me know if it makes sense.

PS: Integration test seems to be broken, but not sure why. I am investigating.

[jonathanKingston]

@shakyShane this reshuffle starts simplifying some of the application structure. It breaks content-feature into two classes, one which autofill can then depend on or use in isolation.

I suggest when Deep gets back we add more testing on this interface so we can add it as a testable interface rather than just letting this barrier to autofill to rot.

This largely is a transitional step, I don't think we want to reside with args wiring still being so complex (i'd like to break the dependency of features heavily relying on them and instead use methods to access that data).

This also simplifies the load and init arguments mostly as a requirement to remove the use of import.meta which I think we agree now was a bit of a mistake. We just then use it at the periphery and don't require autofill to need custom transpiling. importConfig is the transport object for anything that's import.meta related through into the features.

I've reviewed most of this, I'd appreciate a quick look over in case I missed anything. The 4 additional small tiny commits I made just got the integration tests working from a missed setting of args in a method.

[shakyShane]

@jonathanKingston I pushed a commit to fix a type, as mentioned in asana I tested this with complex integrations like duck.ai etc.

[shakyShane]

• poc: preserve comments in esbuild #1565
• injected: replace rollup with esbuild #1521
• [ContentFeature] de-decouple build specific code from content-features #1545 👈 (View in Graphite)
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.