Skip to content

poc: preserve comments in esbuild #1565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 17, 2025
Merged

poc: preserve comments in esbuild #1565

merged 4 commits into from
Mar 17, 2025

Conversation

shakyShane
Copy link
Contributor

@shakyShane shakyShane commented Mar 15, 2025 •
edited
Loading

Asana Task/Github Issue: https://app.asana.com/1/137249556945/project/1201614831475344/task/1204895631127021?focus=true

Description

  • preserve comments from node_modules that include copyright

Testing Steps

  • covered in unit-tests

Checklist

Please tick all that apply:

  • I have tested this change locally
  • I have tested this change locally in all supported browsers
  • This change will be visible to users
  • I have added automated tests that cover this change
  • I have ensured the change is gated by config
  • This change was covered by a ship review
  • This change was covered by a tech design
  • Any dependent config has been merged

This was referenced Mar 15, 2025
Merged
Merged
@shakyShane
Copy link
Contributor Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 15, 2025 •
edited
Loading

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 15, 2025 •
edited
Loading

[Beta] Generated file diff

Time updated: Mon, 17 Mar 2025 13:44:58 GMT

Android 
    - android/brokerProtection.js
  • android/contentScope.js

File has changed

Chrome-mv3 
    - chrome-mv3/inject.js

File has changed

Firefox 
    - firefox/inject.js

File has changed

Integration 
    - integration/contentScope.js

File has changed

Windows 
    - windows/contentScope.js

File has changed

Apple 
    - dist/contentScope.js
  • dist/contentScopeIsolated.js

File has changed

jonathanKingston
jonathanKingston reviewed Mar 15, 2025
View reviewed changes
shakyShane
shakyShane commented Mar 17, 2025
View reviewed changes
@shakyShane shakyShane marked this pull request as ready for review March 17, 2025 13:44
@shakyShane shakyShane requested a review from a team as a code owner March 17, 2025 13:44
@shakyShane shakyShane merged commit 232942e into shane/inject-esbuild Mar 17, 2025
16 checks passed
@shakyShane shakyShane deleted the shane/comments branch March 17, 2025 15:41
jonathanKingston pushed a commit that referenced this pull request Mar 17, 2025
@shakyShane
injected: replace rollup with esbuild (#1521)
2f1ce09 
* injected: replace rollup with esbuild

* fix

* remove suffix

* poc: preserve comments in esbuild (#1565)

* poc: preserve comments in esbuild

* comment

* more test cases

* more test cases

* additional test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathanKingston jonathanKingston jonathanKingston approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shakyShane @jonathanKingston