Skip to content

New Duck Player entry point #1559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 28 commits into from
Mar 28, 2025
Merged

New Duck Player entry point #1559

merged 28 commits into from
Mar 28, 2025

Conversation

mgurgel
Copy link
Contributor

@mgurgel mgurgel commented Mar 13, 2025

Asana Task/Github Issue: https://app.asana.com/1/137249556945/project/72649045549333/task/1209303244719305

Description

Implements the new entry point for Duck Player on mobile

Testing Steps

Regression testing

  1. Check out the main/develop branch of the iOS/Android app
  2. Dynamically import this branch of C-S-S or check out commit e31aa705639e86525d3434f14b8c0fb074261864
  3. Run the app
  4. Set Duck Player to always ask
  5. Search and click on a Duck-playable video on youtube.com
  6. You should see the old Duck Player overlay and be able to interact with it
image

Feature testing

  1. Check out the development branch of one of the apps
    iOS: mgurgel/duckplayer-new-entrypoint
    Android: feature/cris/duck-player/add-new-unique-and-thumbnail-pixels
  2. If on Android, Dynamically import this branch of C-S-S or check out commit e31aa705639e86525d3434f14b8c0fb074261864
  3. Run the app
  4. Load the override remote config
    iOS: https://www.jsonblob.com/api/jsonBlob/1354769799640702976
    Android: https://www.jsonblob.com/api/jsonBlob/1354769985947492352
  5. Set Duck Player to always ask
  6. Search and click on a Duck-playable video on youtube.com
  7. You should see the NEW Duck Player drawer and be able to interact with it
image

Checklist

Please tick all that apply:

  • I have tested this change locally
  • I have tested this change locally in all supported browsers
  • This change will be visible to users
  • I have added automated tests that cover this change
  • I have ensured the change is gated by config
  • This change was covered by a ship review
  • This change was covered by a tech design
  • Any dependent config has been merged

@mgurgel mgurgel requested a review from a team as a code owner March 13, 2025 11:52
Copy link

netlify bot commented Mar 13, 2025

Deploy Preview for content-scope-scripts failed.

Name Link
🔨 Latest commit 0abf3c6
🔍 Latest deploy log https://app.netlify.com/sites/content-scope-scripts/deploys/67e6aeab019b4900089bdb0c

Copy link

github-actions bot commented Mar 13, 2025

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

Copy link

github-actions bot commented Mar 13, 2025

[Beta] Generated file diff

Time updated: Fri, 28 Mar 2025 14:14:44 GMT

Android
    - android/contentScope.js

File has changed

Integration
    - integration/contentScope.js

File has changed

Windows
    - windows/contentScope.js

File has changed

Apple
    - dist/contentScopeIsolated.js

File has changed

@mgurgel mgurgel force-pushed the mgurgel/duckplayer-new-entrypoint branch 2 times, most recently from 0a144b7 to 009cd3c Compare March 26, 2025 11:19
@mgurgel mgurgel changed the title [WIP] New Duck Player entry point New Duck Player entry point Mar 26, 2025
@mgurgel mgurgel force-pushed the mgurgel/duckplayer-new-entrypoint branch 3 times, most recently from 2ecbcbe to 10c15ce Compare March 28, 2025 09:45
@mgurgel mgurgel force-pushed the mgurgel/duckplayer-new-entrypoint branch from 101ad87 to ce53f69 Compare March 28, 2025 13:23
shakyShane
shakyShane previously approved these changes Mar 28, 2025
Copy link
Contributor

@shakyShane shakyShane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested on iOS ✅

@shakyShane
Copy link
Contributor

@mgurgel as mentioned, the important part of this change, is that it can be merged and the old style will still be the default 👍🏻

@mgurgel mgurgel force-pushed the mgurgel/duckplayer-new-entrypoint branch from 8629bd7 to 0abf3c6 Compare March 28, 2025 14:14
@mgurgel mgurgel merged commit 847694d into main Mar 28, 2025
10 of 14 checks passed
@mgurgel mgurgel deleted the mgurgel/duckplayer-new-entrypoint branch March 28, 2025 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants