Skip to content

Refactor overlay logic #1590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 28, 2025
Merged

Refactor overlay logic #1590

merged 1 commit into from
Mar 28, 2025

Conversation

mgurgel
Copy link
Contributor

@mgurgel mgurgel commented Mar 28, 2025

Asana Task/Github Issue:

Description

Testing Steps

Checklist

Please tick all that apply:

  • I have tested this change locally
  • I have tested this change locally in all supported browsers
  • This change will be visible to users
  • I have added automated tests that cover this change
  • I have ensured the change is gated by config
  • This change was covered by a ship review
  • This change was covered by a tech design
  • Any dependent config has been merged

@mgurgel mgurgel requested a review from a team as a code owner March 28, 2025 09:30
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 28, 2025 •
edited
Loading

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 28, 2025 •
edited
Loading

[Beta] Generated file diff

Time updated: Fri, 28 Mar 2025 13:21:47 GMT

Android 
    - android/contentScope.js

File has changed

Integration 
    - integration/contentScope.js

File has changed

Windows 
    - windows/contentScope.js

File has changed

Apple 
    - dist/contentScopeIsolated.js

File has changed

@mgurgel mgurgel force-pushed the mgurgel/duckplayer-new-entrypoint branch from 2ecbcbe to 10c15ce Compare March 28, 2025 09:45
@mgurgel mgurgel mentioned this pull request Mar 28, 2025
Merged
8 tasks
@mgurgel mgurgel force-pushed the mgurgel/duckplayer-new-entrypoint-refactor branch from 7a88905 to 0dc7d16 Compare March 28, 2025 13:21
@mgurgel mgurgel merged commit 101ad87 into mgurgel/duckplayer-new-entrypoint Mar 28, 2025
8 checks passed
@mgurgel mgurgel deleted the mgurgel/duckplayer-new-entrypoint-refactor branch March 28, 2025 13:22
mgurgel added a commit that referenced this pull request Mar 28, 2025
@mgurgel
Refactor overlay logic (#1590)
ce53f69
mgurgel added a commit that referenced this pull request Mar 28, 2025
@mgurgel
Refactor overlay logic (#1590)
5bd6733
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mgurgel