Support arbitary depth config overloading of DOM properties #383
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathanKingston
force-pushed
the
jkt/arbitaryDepthOverloads
branch
from
1eb35ab to
8c04610
Compare
shakyShane
previously approved these changes
Apr 4, 2023
There was a problem hiding this comment.
My only comments on this would be around testing the string output in the future too, to compliment the integration testing.
Since we're just composing a complicated string - I think it would be good to have a base output to compare against (like an actual JS file). It might help surface any problems and would be good for understanding the intention.
On the other hand, it's very hard to construct a string that can be compared against a base one - let's just keep it in mind imo
jonathanKingston
force-pushed
the
jkt/arbitaryDepthOverloads
branch
10 times, most recently
from
f4495f0 to
6201464
Compare
jonathanKingston
force-pushed
the
jkt/arbitaryDepthOverloads
branch
from
6201464 to
113d6eb
Compare
shakyShane
approved these changes
Apr 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: https://app.asana.com/0/0/1204271448367771/f
Allows us to override properties to any depth within the DOM.