Ensure Click to Load events are dispatched at the right times #411
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Click to Load content script needs to communicate with the Click
to Load surrogate scripts sometimes. This is handled by dispatching
events on the page.
If those events are dispatched _before_ the receiving script has
loaded, the events will be missed and aspects of the feature
broken. So let's wait until page load before dispatching them.
That is made harder, by the fact that some of the events must be
dispatched targetting the tracking elements. That way, the receiver
can maintain a lookup of placeholder element <-> tracking element. If
the tracking element is removed _before_ an event is dispatched that
targets it, the event will no longer bubble up the DOM and be
received. To avoid that from happening, let's hide the tracking
element until the events are fired, and then unhide + remove it from
the DOM.
Worse still, it's also important that those events targetting the
tracking (and placeholder) elements are fired _before_ the
"ddg-ctp-ready" event. So let's also take care to wait for all the
element events to fire before sending it!
Note: This all still assumes that the website does not load the
scripts (that are redirected to surrogate scripts) after page
load has completed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@kzar this is your patch rebased over the latest changes in #409 feel free to close this out once done. Just cherry pick this into your branch etc.