Partially revert "Tighten linting" changes to Click to Load code #415
Conversation
Recently, we adjusted the linting rules to make them stricter. While doing that, we made some changes to the Click to Load code to make the linting pass. Unfortunately, that complicated ongoing (and more urgent) changes to that code that are about to land. Let's revert the linting changes to the Click to Load code therefore, while keeping the linting passing + adding a note to revisit.
|
What was the issue? Did you apply #411 over your patch. |
The issue is that the linting changes to the file were quite large, made rebasing hard, and were not especially helpful. Some of the removed async/awaits needed to be readded again, and the many There is much to tidy in this file, but we need to pick our battles. Such a sweeping change to fix linting directly before a new feature is released is bad timing. I intend to come back to that however, once the feature has shipped. |
|
Ok sure, please get a real review before merging #390 There's clear race conditions and unnecessary complexity in that code that put the entire platform at risk. |
Well, for what it's worth I think the ongoing review with @franfaccin is a "real" review (whatever that means). She knows that code better than pretty much anyone.
I guess we can agree to disagree there, since I'll be having ongoing discussions about the best approach on the review with @franfaccin and now @sammacbeth as well. |
Recently, we adjusted the linting rules to make them stricter. While
doing that, we made some changes to the Click to Load code to make the
linting pass. Unfortunately, that complicated ongoing (and more
urgent) changes to that code that are about to land.
Let's revert the linting changes to the Click to Load code therefore,
while keeping the linting passing + adding a note to revisit.