Skip to content

Update Click to Load YouTube (preview-enabled) footer text #436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 18, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 16 additions & 3 deletions src/features/click-to-load.js
Original file line number Diff line number Diff line change
Expand Up @@ -1517,9 +1517,22 @@ function createYouTubePreview (originalElement, widget) {
/** Preview Info Text */
const previewText = document.createElement('div')
previewText.style.cssText = styles.contentText + styles.toggleButtonText + styles.youTubePreviewInfoText
previewText.innerText = widget.replaceSettings.placeholder.previewInfoText + ' '
// Use darkMode styles because of preview background
previewText.appendChild(getLearnMoreLink('darkMode'))
// Since this string contains an anchor element, setting innerText won't
// work.
// Warning: This is not ideal! The translated (and original) strings must be
// checked very carefully! Any HTML they contain will be inserted.
// Ideally, the translation system would allow only certain element
// types to be included, and would avoid the URLs for links being
// included in the translations.
previewText.insertAdjacentHTML(
'beforeend', widget.replaceSettings.placeholder.previewInfoText
)
const previewTextLink = previewText.querySelector('a')
if (previewTextLink) {
const newPreviewTextLink = getLearnMoreLink()
newPreviewTextLink.innerText = previewTextLink.innerText
previewTextLink.replaceWith(newPreviewTextLink)
}

previewToggleRow.appendChild(previewToggle)
previewToggleRow.appendChild(previewText)
Expand Down
2 changes: 1 addition & 1 deletion src/locales/click-to-load/bg/youtube.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion src/locales/click-to-load/cs/youtube.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion src/locales/click-to-load/da/youtube.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion src/locales/click-to-load/de/youtube.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion src/locales/click-to-load/el/youtube.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion src/locales/click-to-load/en/youtube.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion src/locales/click-to-load/es/youtube.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion src/locales/click-to-load/et/youtube.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion src/locales/click-to-load/fi/youtube.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion src/locales/click-to-load/fr/youtube.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion src/locales/click-to-load/hr/youtube.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion src/locales/click-to-load/hu/youtube.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion src/locales/click-to-load/it/youtube.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion src/locales/click-to-load/lt/youtube.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion src/locales/click-to-load/lv/youtube.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion src/locales/click-to-load/nb/youtube.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion src/locales/click-to-load/nl/youtube.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion src/locales/click-to-load/pl/youtube.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion src/locales/click-to-load/pt/youtube.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion src/locales/click-to-load/ro/youtube.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion src/locales/click-to-load/ru/youtube.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion src/locales/click-to-load/sk/youtube.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion src/locales/click-to-load/sl/youtube.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion src/locales/click-to-load/sv/youtube.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion src/locales/click-to-load/tr/youtube.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.