Skip to content

Update Click to Load YouTube (preview-enabled) footer text #436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 18, 2023

Conversation

kzar
Copy link
Contributor

@kzar kzar commented Apr 17, 2023

During internal review, it was requested that we change the
footer-text for Click to Load YouTube placeholders.

@kzar kzar requested a review from ladamski as a code owner April 17, 2023 14:42
@kzar kzar force-pushed the fix-ctl-youtube-placeholders-p10 branch 2 times, most recently from 061f332 to 8c70987 Compare April 17, 2023 14:52
@kzar kzar force-pushed the fix-ctl-youtube-placeholders-p10 branch from 8c70987 to 8c6e846 Compare April 17, 2023 15:38
ladamski
ladamski previously approved these changes Apr 17, 2023
Copy link
Contributor

@ladamski ladamski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this and LGTM! The only small nit maybe is that the "Learn more" currently opens in the active tab, I would expect this to open a new tab or window instead?

During internal review, it was requested that we change the
footer-text for Click to Load YouTube placeholders.
@kzar kzar force-pushed the fix-ctl-youtube-placeholders-p10 branch from 8c6e846 to 6c44f1b Compare April 18, 2023 15:03
@ladamski ladamski self-requested a review April 18, 2023 18:21
Copy link
Contributor

@ladamski ladamski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kzar kzar merged commit 6b90921 into duckduckgo:main Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants