Skip to content

Remove bundled ProximaNova font #448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 24, 2023
Merged

Remove bundled ProximaNova font #448

merged 5 commits into from
Apr 24, 2023

Conversation

sammacbeth
Copy link
Contributor

@sammacbeth sammacbeth commented Apr 20, 2023 •
edited
Loading

  • Removes ProximaNova font in CTL assets.
  • Adds a mechanism for the platform to send asset URLs for custom fonts on init, allowing CTL fonts to be customized.
  • We can use this in the extension to use bundled fonts that work in all locales (see duckduckgo/duckduckgo-privacy-extension@3ca91a6)
  • For platforms that don't send asset URLs, they get system default fonts that match the privacy-dashboard.

jonathanKingston
jonathanKingston reviewed Apr 20, 2023
View reviewed changes
jonathanKingston
jonathanKingston reviewed Apr 20, 2023
View reviewed changes
@sammacbeth sammacbeth marked this pull request as ready for review April 21, 2023 14:50
@sammacbeth sammacbeth changed the title Remove bundled ProxmiaNova font Remove bundled ProximaNova font Apr 21, 2023
jonathanKingston
jonathanKingston approved these changes Apr 24, 2023
View reviewed changes
Copy link
Contributor

@jonathanKingston jonathanKingston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)

@sammacbeth sammacbeth merged commit 0d89cd0 into main Apr 24, 2023
@sammacbeth sammacbeth deleted the sam/ctl-fonts branch April 24, 2023 08:55
sammacbeth added a commit to sammacbeth/duckduckgo-privacy-extension that referenced this pull request Apr 24, 2023
@sammacbeth
Add 'assets' to arguments objects with bundled font URLs
3c32d8a 
- see duckduckgo/content-scope-scripts#448
sammacbeth added a commit to duckduckgo/duckduckgo-privacy-extension that referenced this pull request Apr 24, 2023
@sammacbeth
Remove fonts from repo and fetch at build time (#1903)
0414df2 
* Remove fonts from repo and fetch at build time

* Bump privacy-dashboard

* Fix whitespace use

* Add 'assets' to arguments objects with bundled font URLs

- see duckduckgo/content-scope-scripts#448
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kzar kzar kzar approved these changes

@jonathanKingston jonathanKingston jonathanKingston approved these changes

@ladamski ladamski Awaiting requested review from ladamski

@shakyShane shakyShane Awaiting requested review from shakyShane

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sammacbeth @kzar @jonathanKingston