Setting java boot classpath so that scala 2.10 works on gradle 7.2 #1800
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbaiera
approved these changes
Nov 8, 2021
mark-vieira
pushed a commit
that referenced
this pull request
Dec 2, 2021
…1800) Gradle 7.2 broke scala 2.10 compilation. The problem seems to be that the java boot classpath jars are no longer getting into the scala boot classpath. This commit sets it in two ways: (1) it is explicitly set it in scalaCompileOptions.additionalParameters (to prevent the build from failing) and (2) it is set in options.bootstrapClasspath to prevent warnings from javac that its boot classpath is incompatible with the source version.
masseyke
added a commit
to masseyke/elasticsearch-hadoop
that referenced
this pull request
Feb 23, 2022
…lastic#1800) Gradle 7.2 broke scala 2.10 compilation. The problem seems to be that the java boot classpath jars are no longer getting into the scala boot classpath. This commit sets it in two ways: (1) it is explicitly set it in scalaCompileOptions.additionalParameters (to prevent the build from failing) and (2) it is set in options.bootstrapClasspath to prevent warnings from javac that its boot classpath is incompatible with the source version.
masseyke
added a commit
that referenced
this pull request
Feb 23, 2022
* Setting java boot classpath so that scala 2.10 works on gradle 7.2 (#1800) Gradle 7.2 broke scala 2.10 compilation. The problem seems to be that the java boot classpath jars are no longer getting into the scala boot classpath. This commit sets it in two ways: (1) it is explicitly set it in scalaCompileOptions.additionalParameters (to prevent the build from failing) and (2) it is set in options.bootstrapClasspath to prevent warnings from javac that its boot classpath is incompatible with the source version. * Update Gradle wrapper to 7.3 (#1809) Co-authored-by: Mark Vieira <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building scala 2.10 code stopped working when I upgraded to gradle 7.2 (scala 2.11 and 2.12 continued working
fine). I still don't fully understand it, but the problem seems to be that the java boot classpath jars are no longer
getting into the scala boot classpath. I found that I had to set it in two ways: (1) I have to explicitly set it in
scalaCompileOptions.additionalParameters or the build fails and (2) I have to set it in options.bootstrapClasspath
or I get warnings from javac that its boot classpath is incompatible with the source version. The two commands
I've been using to test this out are:
and