Skip to content

Update Gradle wrapper to 7.3 #1809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 2, 2021
Merged

Update Gradle wrapper to 7.3 #1809

merged 1 commit into from
Dec 2, 2021

Conversation

mark-vieira
Copy link
Contributor

Update Gradle to 7.3 which includes Java 17 support.

@mark-vieira mark-vieira requested a review from jbaiera December 1, 2021 21:22
@masseyke masseyke self-requested a review December 2, 2021 14:59
Copy link
Member

@masseyke masseyke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still have to run with --warning-mode=none (I had fixed some of these problems in #1792 but there are still more), but otherwise looks good to me.

@mark-vieira mark-vieira merged commit 37b6621 into master Dec 2, 2021
@mark-vieira mark-vieira deleted the update_gradle_7.3 branch December 2, 2021 19:08
mark-vieira added a commit that referenced this pull request Dec 2, 2021
@masseyke masseyke mentioned this pull request Dec 3, 2021
masseyke pushed a commit to masseyke/elasticsearch-hadoop that referenced this pull request Feb 23, 2022
masseyke added a commit that referenced this pull request Feb 23, 2022
* Setting java boot classpath so that scala 2.10 works on gradle 7.2 (#1800)

Gradle 7.2 broke scala 2.10 compilation. The problem seems to be that the java boot classpath jars are
no longer getting into the scala boot classpath. This commit sets it in two ways: (1) it is explicitly set it
in scalaCompileOptions.additionalParameters (to prevent the build from failing) and (2) it is set in options.bootstrapClasspath to prevent warnings from javac that its boot classpath is incompatible with
the source version.

* Update Gradle wrapper to 7.3 (#1809)

Co-authored-by: Mark Vieira <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants