Update codegen task to be runnable via CI #1944
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This seems to be the only missing piece in order to take advantage of automatic daily code generation via the GitHub action https://github.com/elastic/language-clients/actions/workflows/generate-clients-code.yml
picandocodigo
approved these changes
Jul 17, 2023
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.8 8.8
# Navigate to the new working tree
cd .worktrees/backport-8.8
# Create a new branch
git switch --create backport-1944-to-8.8
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 6fef22d387440e041b540b8498ec2757ce5ff92a
# Push it to GitHub
git push --set-upstream origin backport-1944-to-8.8
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.8Then, create a pull request where the |
github-actions bot
pushed a commit
that referenced
this pull request
Aug 17, 2023
(cherry picked from commit 6fef22d)
This was referenced Aug 17, 2023
Merged
JoshMock
added a commit
that referenced
this pull request
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the
codegentask so that it can be run by CI. Tested via our manual GitHub action and it successfully created #1943. 🎉