Set up repo to support automated codegen #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Equivalent to recent changes made to the stack client
.ci/Dockerfile
Outdated
| RUN npm install | ||
|
|
||
| COPY . . | ||
| COPY --chown=$BUILDER_USER:$BUILDER_GROUP . . |
There was a problem hiding this comment.
Just yesterday I cleaned up the elasticsearch-ruby Dockerfile. All this user/group configuration was needed for the snapshot builds so the release manager could pick up the generated zip file. I think we can remove it now to make our Dockerfiles simpler.
There was a problem hiding this comment.
Good to know.
I ran into a pain point where not including --chown when running locally would set all the build artifacts and my node_modules to be owned by root. That's more of a personal inconvenience, though, so I'm sure I can find a way to work around it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copying changes from elastic/elasticsearch-js#1944.
Also updates to use a serverless version number that includes date metadata.