Skip to content

SLM config and retention are optional #1951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 6, 2022
Merged

SLM config and retention are optional #1951

merged 1 commit into from
Oct 6, 2022

Conversation

swallez
Copy link
Member

@swallez swallez commented Oct 6, 2022

Fixes #1917

The config and retention fields in the SLM policy are optional, and also indices in config.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2022

Following you can find the validation results for the APIs you have changed.

API Status Request Response
slm.delete_lifecycle 🟢 4/4 4/4
slm.execute_lifecycle 🟢 4/4 4/4
slm.execute_retention 🟢 4/4 4/4
slm.get_lifecycle 🟢 16/16 16/16
slm.get_stats 🟢 4/4 4/4
slm.get_status 🟢 4/4 4/4
slm.put_lifecycle 🟢 4/4 4/4
slm.start Missing test Missing test
slm.stop 🟢 4/4 4/4

You can validate these APIs yourself by using the make validate target.

@@ -74,10 +74,10 @@ export class Statistics {
}

export class Policy {
Copy link
Contributor

@sethmlarson sethmlarson Oct 6, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this another case of Policy/PolicyRead? If so can we split into two and use @OverloadOf?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue was reported for a read operation, and I checked the code: parsing and serialization are symmetrical and have the same tests for those optional properties.

Copy link
Contributor

@sethmlarson sethmlarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SLM Java Client Missing Required Policy Config Element (indices)
2 participants