Skip to content

SLM config and retention are optional #1951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 6, 2022
Merged

SLM config and retention are optional #1951

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions output/schema/schema.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions output/typescript/types.ts
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions specification/slm/_types/SnapshotLifecycle.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,10 +74,10 @@ export class Statistics {
}

export class Policy {
Copy link
Contributor

@sethmlarson sethmlarson Oct 6, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this another case of Policy/PolicyRead? If so can we split into two and use @OverloadOf?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue was reported for a read operation, and I checked the code: parsing and serialization are symmetrical and have the same tests for those optional properties.

config: Configuration
config?: Configuration
name: Name
repository: string
retention: Retention
retention?: Retention
schedule: CronExpression
}

Expand Down Expand Up @@ -106,7 +106,7 @@ export class Configuration {
* A comma-separated list of data streams and indices to include in the snapshot. Multi-index syntax is supported.
* By default, a snapshot includes all data streams and indices in the cluster. If this argument is provided, the snapshot only includes the specified data streams and clusters.
*/
indices: Indices
indices?: Indices
/**
* If true, the current global state is included in the snapshot.
* @server_default true
Expand Down