Add Search Applications API #2080
Conversation
There was a problem hiding this comment.
Looks great, thanks for doing this @carlosdelest ! One comment.
| "responseMediaType": [ | ||
| "application/json" | ||
| ], | ||
| "since": "8.8.0", | ||
| "stability": "beta", |
There was a problem hiding this comment.
I think we need to change the stability of search applications from beta to tech preview right?
There was a problem hiding this comment.
I was thinking on having first input from the clients team - we need to do that change in the ES specs as well so it gets propagated here. Thanks for the reminder!
There was a problem hiding this comment.
The API docs have already been updated! elastic/elasticsearch#95308
| */ | ||
| name: Name | ||
| } | ||
| /** @codegen_name search_params */ |
There was a problem hiding this comment.
If the fields in the request body are parameters in their own right (rather than say, a model definition) then you don't need a codegen_name here. Having a @codegen_name for the body will treat the entire body as one parameter, rather than the individual fields in the body as parameters.
There was a problem hiding this comment.
Thanks @sethmlarson ! There were validation errors that pointed to using codegen_name so I included that. Removing this!
|
Closing this PR to open from the same repo, so Github actions are successful |
Add Search Applications API, including both CRUD and
_searchrequest.