-
Notifications
You must be signed in to change notification settings - Fork 102
Add Search Applications API #2082
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great so far, a couple comments! 💯
"responseMediaType": [ | ||
"application/json" | ||
], | ||
"since": "8.8.0", | ||
"stability": "beta", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like we may need to update the stability here to experimental as well?
* Returns the details about a search application | ||
* @rest_spec_name search_application.get | ||
* @since 8.8.0 | ||
* @stability beta |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to update these @stability
tags too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me!
@kderusso We'll eventually need to update the stability tags, but I was thinking we could get this PR merged and then I'll manually resync the rest-api-spec
stubs before fixing the stabilities. Otherwise we need to resync, rebase, and all that, might be easier this way?
@kderusso , as @sethmlarson said, this can be done in a separate PR with the syncs already done. I'm merging this PR and we'll take care of that in a separate one 👍 |
Add Search Applications API, including both CRUD and _search request.
Reopening this from #2080, as Github actions need the PR to be done from the same repo