-
Notifications
You must be signed in to change notification settings - Fork 102
Update resolve index missing type definition #2856
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Following you can find the validation results for the API you have changed.
You can validate this API yourself by using the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this looks good! Can you please remove the _json_spec
change for now?
Also, as a follow-up and only if you're interested, we could add allow_no_indices
that is also missing.
}, | ||
"ignore_unavailable": { | ||
"type": "boolean", | ||
"description": "Ignore unavailable indexes (default: false)" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The source of truth of the _json_spec
folder is in Elasticsearch, see https://github.com/elastic/elasticsearch/blob/main/rest-api-spec/src/main/resources/rest-api-spec/api/indices.resolve_index.json. Can you please open an Elasticsearch pull request? Otherwise this will change will be overwritten in our next weekly sync.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Following you can find the validation results for the API you have changed.
You can validate this API yourself by using the |
Following you can find the validation results for the API you have changed.
You can validate this API yourself by using the |
Following you can find the validation results for the API you have changed.
You can validate this API yourself by using the |
* Update resolve index missing type definition * Add allow_no_indices * Fix Markdown syntax in allow_no_indices * Run make contrib --------- Co-authored-by: Quentin Pradet <[email protected]> (cherry picked from commit f24570e)
This PR adds the missing type definition for
ignore_unavailable
andallow_no_indices
query param` which are accepted by ES but the definition is missing.