Skip to content

Update rest-api-spec 8.15 #2876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 9, 2024
Merged

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Sep 7, 2024

As titled.

@@ -7,8 +7,7 @@
"stability": "stable",
"visibility": "public",
"headers": {
"accept": ["application/json"],
"content_type": ["application/json"]
"accept": ["application/json"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pquentin isn't this what you fixed the other day for the python client? is there a way we can ignore this?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! I opened elastic/elasticsearch#112581 late last week to fix this but it took a bit of time to be merged and backported to 8.15. Then the Elasticsearch build was failing over the weekend so there was no available artifact with the changes. Thankfully the Elasticsearch build passed during the night and this diff was thus removed automatically from this pull request.

@l-trotta
Copy link
Contributor

l-trotta commented Sep 8, 2024

The validation errors seem to be outdated, the two missing parameters were recently added

@github-actions github-actions bot force-pushed the automated/rest-api-spec-update-8.15 branch from dc50e1a to f89b77d Compare September 9, 2024 04:06
@github-actions github-actions bot requested a review from l-trotta September 9, 2024 04:06
@pquentin
Copy link
Member

pquentin commented Sep 9, 2024

The validation errors seem to be outdated, the two missing parameters were #2856

Actually, the errors here got solved because a change in Elasticsearch resolved the diff between the JSON spec and the Elasticsearch specification. It's good new, not bad news!

Copy link
Member

@pquentin pquentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This now looks good to me but I'd appreciate if someone could confirm my reasoning here.

@pquentin pquentin merged commit 3461525 into 8.15 Sep 9, 2024
1 check passed
@pquentin pquentin deleted the automated/rest-api-spec-update-8.15 branch September 9, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants