Skip to content

Fix code style #2861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 5, 2024
Merged

Fix code style #2861

merged 1 commit into from
Sep 5, 2024

Conversation

pquentin
Copy link
Member

@pquentin pquentin commented Sep 5, 2024

#2829 was merged after #2853, and introduced an import error.

Copy link
Contributor

github-actions bot commented Sep 5, 2024

Following you can find the validation results for the API you have changed.

API Status Request Response
open_point_in_time 🟢 7/7 7/7

You can validate this API yourself by using the make validate target.

@pquentin pquentin merged commit 02c55e1 into main Sep 5, 2024
6 checks passed
@pquentin pquentin deleted the fix-prettier branch September 5, 2024 11:41
Copy link
Contributor

github-actions bot commented Sep 6, 2024

The backport to 8.15 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.15 8.15
# Navigate to the new working tree
cd .worktrees/backport-8.15
# Create a new branch
git switch --create backport-2861-to-8.15
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 02c55e1391167fa393559fd262c697acb630e5e5
# Push it to GitHub
git push --set-upstream origin backport-2861-to-8.15
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.15

Then, create a pull request where the base branch is 8.15 and the compare/head branch is backport-2861-to-8.15.

Copy link
Contributor

github-actions bot commented Sep 6, 2024

The backport to 8.14 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.14 8.14
# Navigate to the new working tree
cd .worktrees/backport-8.14
# Create a new branch
git switch --create backport-2861-to-8.14
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 02c55e1391167fa393559fd262c697acb630e5e5
# Push it to GitHub
git push --set-upstream origin backport-2861-to-8.14
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.14

Then, create a pull request where the base branch is 8.14 and the compare/head branch is backport-2861-to-8.14.

@pquentin
Copy link
Member Author

pquentin commented Sep 6, 2024

I wanted to backport #2853, not this one. Indeed, this pull request is only needed because of #2829 which is 8.16 only.

I removed the backport labels.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants