Making async esql responses binary #3639
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
pquentin
approved these changes
Jan 29, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Jan 29, 2025
(cherry picked from commit 98f0633)
github-actions bot
pushed a commit
that referenced
this pull request
Jan 29, 2025
(cherry picked from commit 98f0633)
l-trotta
added a commit
that referenced
this pull request
Jan 29, 2025
* making response binary (#3639) (cherry picked from commit 98f0633) * change back esql format package --------- Co-authored-by: Laura Trotta <[email protected]> Co-authored-by: Laura Trotta <[email protected]>
l-trotta
added a commit
that referenced
this pull request
Jan 29, 2025
* making response binary (#3639) (cherry picked from commit 98f0633) * change back esql format package --------- Co-authored-by: Laura Trotta <[email protected]> Co-authored-by: Laura Trotta <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The esql async API response format varies depending on the format chosen in the request, also it's not supported when using formats that are not json compatible (so it only supported by json, yaml, cbor, smile). The spec as it is only supports json results, so all the responses should be changed to a binary representation, and the clients will choose which to support.
In the backports PR the package change for EsqlFormat will be reversed, as it is a breaking change that we can introduce in the next major.