Skip to content

Making async esql responses binary #3639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 29, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 4 additions & 32 deletions output/openapi/elasticsearch-openapi.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions output/openapi/elasticsearch-serverless-openapi.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions output/schema/schema-serverless.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

84 changes: 18 additions & 66 deletions output/schema/schema.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

15 changes: 4 additions & 11 deletions output/typescript/types.ts

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions specification/_types/Binary.ts
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,8 @@
// Vector tile response
export type MapboxVectorTiles = ArrayBuffer

// ES|QL columns
export type EsqlColumns = ArrayBuffer
// ES|QL generic response
export type EsqlResult = ArrayBuffer

// Streaming endpoints response
export type StreamResult = ArrayBuffer
20 changes: 2 additions & 18 deletions specification/esql/async_query/AsyncQueryResponse.ts
Original file line number Diff line number Diff line change
Expand Up @@ -17,24 +17,8 @@
* under the License.
*/

import { EsqlColumns } from '@_types/Binary'
import { EsqlResult } from '@_types/Binary'

export class Response {
body: {
columns?: EsqlColumns
/**
* A query identifier that is provided only when one of the following conditions is met:
*
* * A query request does not return complete results during the period specified in the `wait_for_completion_timeout` parameter.
* * The `keep_on_completion` parameter value is true.
*
* You can use this ID with the `GET /_query/async/<id>` API to get the current status and available results for the query.
*/
id?: string
/**
* Indicates whether the query is still running.
* If the value is false, the async query has finished and the results are returned.
*/
is_running: boolean
}
body: EsqlResult
}
11 changes: 2 additions & 9 deletions specification/esql/async_query_get/AsyncQueryGetResponse.ts
Original file line number Diff line number Diff line change
Expand Up @@ -17,15 +17,8 @@
* under the License.
*/

import { EsqlColumns } from '@_types/Binary'
import { EsqlResult } from '@_types/Binary'

export class Response {
body: {
columns?: EsqlColumns
/**
* Indicates whether the query is still running.
* If the value is false, the async query has finished and the results are returned.
*/
is_running: boolean
}
body: EsqlResult
}
4 changes: 2 additions & 2 deletions specification/esql/query/QueryResponse.ts
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,9 @@
* under the License.
*/

import { EsqlColumns } from '@_types/Binary'
import { EsqlResult } from '@_types/Binary'

export class Response {
/** @codegen_name data */
body: EsqlColumns
body: EsqlResult
}