[ci] add jobs to run the acceptance tests #1
Conversation
.ci/jobs/defaults.yml
Outdated
|
|
||
| - job: | ||
| project-type: pipeline | ||
| prune-dead-branches: true |
There was a problem hiding this comment.
I think this is only valid for multibranch pipeline jobs.
.ci/jobs/defaults.yml
Outdated
| - meta: | ||
| cluster: devops-ci |
There was a problem hiding this comment.
For these top-level properties, the child items need to be indented or the YAML won't get parsed correctly.
| - meta: | |
| cluster: devops-ci | |
| - meta: | |
| cluster: devops-ci |
|
|
||
| ##### JOB DEFAULTS | ||
|
|
||
| - job: |
There was a problem hiding this comment.
Same issue as above, the other properties that are part of the job map need to be indented.
| @@ -0,0 +1,13 @@ | |||
| --- | |||
| - job: | |||
| name: elastic+terraform-provider-elasticstack+main | |||
There was a problem hiding this comment.
Same indentation comment as elsewhere.
| @@ -0,0 +1,21 @@ | |||
| --- | |||
| - job: | |||
| name: elastic+terraform-provider-elasticstack+pull-request | |||
There was a problem hiding this comment.
Same indentation comment as elsewhere.
| name: elastic+terraform-provider-elasticstack+main | ||
| display-name: elastic / terraform-provider-elasticstack - main | ||
| description: Main branch testing | ||
| project-type: pipeline |
There was a problem hiding this comment.
If you have this set in the defaults you could get away with not setting it in the jobs.
| name: elastic+terraform-provider-elasticstack+pull-request | ||
| display-name: elastic / terraform-provider-elasticstack - pull-request | ||
| description: Pull request testing | ||
| project-type: pipeline |
There was a problem hiding this comment.
If you have this set in the defaults you could get away with not setting it in the jobs.
|
@jonahbull thanks for the review and pointing out the formatting issues. Looks like I overdid the formatting steps after some local testing 😄 . Please, take another look. |
* Add URL support to data_view field_formats (#1) - Adds support for `urlTemplate` and `labelTemplate` to data_views.field_formats - Amends API request build process to account for when some/any data_views.field_formats.attributes aren't passed in * Update internal/kibana/data_view/schema.go Co-authored-by: Toby Brain <[email protected]> * Update internal/kibana/data_view/schema.go Co-authored-by: Toby Brain <[email protected]> * PR changes --------- Co-authored-by: Toby Brain <[email protected]>
Adding CI jobs to run the acceptance testing: