Fixes #12299 #12324
Closed
Fixes #12299 #12324
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josevalim
reviewed
Jan 8, 2023
| # TODO handle unescapable values which are deeper in the structure | ||
| {key, value} when is_reference(x) or is_pid(x) or is_port(x) -> {key, nil} | ||
| {key, value} -> {key, value} | ||
| end) |
There was a problem hiding this comment.
Unfortunately this is much more expensive. I think you can do:
env = put_in(env.lexical_tracker, nil)
and that should be it. We don't have any improper fields anywhere else. :)
If you want, you can add a test that traverses the result of Macro.expand recursively and verifies there is no improper data. :)
|
@josevalim , thanks for closing the issue, I am sorry that I didn't finish it, I just don't have enough time for opensource right now |
|
It is no worries, I had to take a look at it anyway, because returning |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.