Add :sort_maps to Inspect.Opts.custom_options #12404
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sabiwara
commented
Feb 16, 2023
| list = Map.to_list(map) | ||
| list = | ||
| if Keyword.get(opts.custom_options, :sort_maps) do | ||
| map |> Map.to_list() |> :lists.sort() |
There was a problem hiding this comment.
I benched this with the new :maps.iterator(map, :ordered): sabiwara/elixir_benches@71055e9, but this implementation has the benefit of:
- being faster or equivalent
- using half as much memory
- work on OTP < 26
So I went with this one instead.
whatyouhide
approved these changes
Feb 16, 2023
Co-authored-by: Andrea Leopardi <[email protected]>
|
💚 💙 💜 💛 ❤️ |
josevalim
pushed a commit
that referenced
this pull request
Feb 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
:sort_mapstoInspect.Opts.custom_optionsin order to make inspect tests deterministic and fix them in OTP26.Note: other tests like
Enumtests also need to be fixed, will do it in a separate PR.