Fix Enum tests for maps in OTP26 #12405
Conversation
| seed1 = {1406, 407_414, 139_258} | ||
| seed2 = {1406, 421_106, 567_597} | ||
| :rand.seed(:exsss, seed1) | ||
| assert Enum.take_random(map, 1) == [c: 3] | ||
| assert Enum.take_random(map, 1) == [x3] |
There was a problem hiding this comment.
I took this approache here, but I'm not sure if it's the best here. Maybe these tests could actually be removed and more property-based testing could be added in StreamData?
There was a problem hiding this comment.
These tests are silly in a way but important because we often have special clauses for lists, so we need to test the enum implementations. The other option is to use MapSet, but they don't guarantee order as well, so...
If we had a queue :D
There was a problem hiding this comment.
Oh, I see!
If we want something that's a) ordered and b) not optimized (rules out ranges), I think streams could be a nice candidate? Something like:
https://github.com/elixir-lang/elixir/compare/main...sabiwara:elixir:use-stream-for-enum-tests?expand=1
If there's interest, I can open up a PR.
Noted for the queue ;) (but this might be optimizeable too)
There was a problem hiding this comment.
Yes, streams are an option and we have tests with them too. But I would only add tests, the changes you did are great.
There was a problem hiding this comment.
So basically keep EnumTest.Map but add EnumTest.Stream as well?
There was a problem hiding this comment.
If necessary, surely, but i assume we are well covered? :)
|
💚 💙 💜 💛 ❤️ |
Make
Enumtests for maps independent of Map ordering, in order to fix tests for OTP26. (see also: #12404)