-
-
Notifications
You must be signed in to change notification settings - Fork 113
Added useful links to landing page #559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some small requests, thanks for contributing!
</li> | ||
<li> | ||
<h5> | ||
<a href="https://guides.emberjs.com/v1.10.0/concepts/core-concepts/">Core Concepts</a> - |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe we should be linking to /release
instead of v1.10.0
here, can you update?
<ul> | ||
<li> | ||
<h5> | ||
<a href="https://github.com/ember-learn/ember-api-docs">API Documentation</a> - |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
API Documentation Viewer Source Code
instead of API Documentation
. Just "API Documentation" suggests that the link goes to the actual documentation content which will confuse people.
<li> | ||
<h5> | ||
<a href="https://guides.emberjs.com/release/getting-started/core-concepts/">Core Concepts</a> - | ||
Ember core concepts documentation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The description is repetitive to the title. A better description might be something like "An overview of some foundational Ember concepts"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of this link why not just link to the front page of the guides: https://guides.emberjs.com/release/ and mention in the description that the guides document foundational concepts in Ember.
Thank you! |
start fixing a few links in state management
Following issue #518
Added 2 links