Skip to content

Added useful links to landing page #559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 29, 2019
Merged

Conversation

honeyspoon
Copy link
Contributor

Following issue #518
Added 2 links

  • A link to the API docs GitHub repository
  • A link to the ember Core concepts documentation

locks
locks previously requested changes Oct 4, 2018
Copy link
Contributor

@locks locks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some small requests, thanks for contributing!

</li>
<li>
<h5>
<a href="https://guides.emberjs.com/v1.10.0/concepts/core-concepts/">Core Concepts</a> -
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we should be linking to /release instead of v1.10.0 here, can you update?

@honeyspoon
Copy link
Contributor Author

Here is a screenshot of how it looks on my end

screen shot 2018-10-04 at 5 51 14 am

@locks locks temporarily deployed to ead-review-app-pr-559 October 11, 2018 03:20 Inactive
<ul>
<li>
<h5>
<a href="https://github.com/ember-learn/ember-api-docs">API Documentation</a> -
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API Documentation Viewer Source Code instead of API Documentation. Just "API Documentation" suggests that the link goes to the actual documentation content which will confuse people.

<li>
<h5>
<a href="https://guides.emberjs.com/release/getting-started/core-concepts/">Core Concepts</a> -
Ember core concepts documentation
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The description is repetitive to the title. A better description might be something like "An overview of some foundational Ember concepts"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of this link why not just link to the front page of the guides: https://guides.emberjs.com/release/ and mention in the description that the guides document foundational concepts in Ember.

@toddjordan
Copy link
Contributor

Thank you!

Gaurav0 pushed a commit to Gaurav0/ember-api-docs that referenced this pull request Sep 16, 2019
start fixing a few links in state management
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants