Skip to content

Added useful links to landing page #559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 29, 2019
Merged

Added useful links to landing page #559

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a87e10b
added useful links to landing page
honeyspoon Oct 2, 2018
a6969ee
GitHub should have a capital h
honeyspoon Oct 4, 2018
601ae2f
Updated ember core docs link to 'release' version
honeyspoon Oct 4, 2018
7055a6b
Simplify "Useful Links"
toddjordan Mar 28, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions app/templates/project-version/index.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,4 +36,19 @@
<p>
The most up-to-date and complete mappings between the previous API and the new JavaScript Modules API can be found at the <a href='https://github.com/ember-cli/ember-rfc176-data'>ember-rfc176-data</a> repository. <a href='https://github.com/tomdale/ember-modules-codemod'>Codemod tooling</a> is also available to help migrate existing Ember projects to the new JavaScript Modules API syntax.
</p>
<h2>Useful links</h2>
<ul>
<li>
<h5>
<a href="https://github.com/ember-learn/ember-api-docs">API Documentation</a> -
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API Documentation Viewer Source Code instead of API Documentation. Just "API Documentation" suggests that the link goes to the actual documentation content which will confuse people.

GitHub repository
</h5>
</li>
<li>
<h5>
<a href="https://guides.emberjs.com/release/getting-started/core-concepts/">Core Concepts</a> -
Ember core concepts documentation
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The description is repetitive to the title. A better description might be something like "An overview of some foundational Ember concepts"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of this link why not just link to the front page of the guides: https://guides.emberjs.com/release/ and mention in the description that the guides document foundational concepts in Ember.

</h5>
</li>
</ul>
</article>