Improve Ember Data Overview heading #852
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the Ember Data overview is showing, give a more reasonable title instead of "Package ember-data-overview"
runspired
approved these changes
Jan 27, 2023
| @@ -1,5 +1,9 @@ | |||
| <article class="chapter"> | |||
| <h1 class="module-name">Package {{this.model.name}}</h1> | |||
| {{#if (eq this.model.name 'ember-data-overview')}} | |||
| <h1 class="module-name">Ember Data Overview</h1> | |||
There was a problem hiding this comment.
Suggest just Overview, but if you want to keep EmberData let's style it without the space.
There was a problem hiding this comment.
I updated this to remove the space. I think including EmberData in an h1 will help with search results.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the Ember Data overview is showing, give a more reasonable title instead of "Package ember-data-overview"
Before
After