Skip to content

Improve Ember Data Overview heading #852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 31, 2023
Merged

Improve Ember Data Overview heading #852

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
70d3084
Conditional Ember Data header
jenweber Jan 27, 2023
b4c448e
Update Ember Data spacing
jenweber Jan 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion app/templates/project-version/modules/module.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
<article class="chapter">
<h1 class="module-name">Package {{this.model.name}}</h1>
{{#if (eq this.model.name 'ember-data-overview')}}
<h1 class="module-name">Ember Data Overview</h1>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest just Overview, but if you want to keep EmberData let's style it without the space.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated this to remove the space. I think including EmberData in an h1 will help with search results.

{{else}}
<h1 class="module-name">Package {{this.model.name}}</h1>
{{/if}}
{{#if this.model.access}}<span class="access">{{this.model.access}}</span>{{/if}}

<p class="attributes">
Expand Down