Add NODEFS readdir test case #15308
Closed
Add NODEFS readdir test case #15308
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
reviewed
Oct 15, 2021
tests/test_core.py
Outdated
| @@ -5274,6 +5274,10 @@ def test_fs_nodefs_home(self): | |||
| self.emcc_args += ['-lnodefs.js'] | |||
| self.do_runf(test_file('fs/test_nodefs_home.c'), 'success', js_engines=[config.NODE_JS]) | |||
|
|
|||
| def test_nodefs_list_dir(self): | |||
There was a problem hiding this comment.
The other tests here seem to prefix their name with test_fs_
sbc100
reviewed
Oct 15, 2021
|
@sbc100 I originally thought that I could create a simple fix for the listing of directories with NODEFS. Unfortunately my "fix" didn't fix anything for existing subfolders and my knowledge of emscripten FS is not good enough to provide a proper fix... The provided test case nevertheless shouldn't lead to a hard crash. |
Closed
sbc100
added a commit
that referenced
this pull request
Jan 27, 2022
The test case here was taken from #15308. The main bugfix here is to use `stream.node` rather than just `stream` when attempting to get node properties from a stream. There were some extra properties added to the streams back in #15167, but this change reverts that and instread fixes up the streams returned by NODERAWFS such that they have the correct/expected fields.
sbc100
added a commit
that referenced
this pull request
Jan 27, 2022
The test case here was taken from #15308. The main bugfix here is to use `stream.node` rather than just `stream` when attempting to get node properties from a stream. There were some extra properties added to the streams back in #15167, but this change reverts that and instread fixes up the streams returned by NODERAWFS such that they have the correct/expected fields.
sbc100
added a commit
that referenced
this pull request
Jan 27, 2022
The test case here was taken from #15308. The main bugfix here is to use `stream.node` rather than just `stream` when attempting to get node properties from a stream. There were some extra properties added to the streams back in #15167, but this change reverts that and instread fixes up the streams returned by NODERAWFS such that they have the correct/expected fields.
sbc100
added a commit
that referenced
this pull request
Jan 27, 2022
The test case here was taken from #15308. The main bugfix here is to use `stream.node` rather than just `stream` when attempting to get node properties from a stream. There were some extra properties added to the streams back in #15167, but this change reverts that and instread fixes up the streams returned by NODERAWFS such that they have the correct/expected fields.
sbc100
added a commit
that referenced
this pull request
Jan 28, 2022
The test case here was taken from #15308. The main bugfix here is to use `stream.node` rather than just `stream` when attempting to get node properties from a stream. There were some extra properties added to the streams back in #15167, but this change reverts that and instead fixes up the streams returned by NODERAWFS such that they have the correct/expected fields.
|
I just landed #16124 which I think fixes this issue, and uses the test case from this PR. So I think this can now be closes? |
|
Sounds good. Thanks for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit #15167 introduced a bug in __syscall_getdents64.
Without this fix a simple dir listing of a mounted directory leads to a crash.