Fix for getdents (readdir) under NODEFS. #16124
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
fix_nodefs_readdir
branch
from
e07a267 to
448407b
Compare
|
It looks good to me? I don't really know this code very well though. |
dschuff
reviewed
Jan 27, 2022
kripken
reviewed
Jan 27, 2022
sbc100
force-pushed
the
fix_nodefs_readdir
branch
from
448407b to
d698e09
Compare
kripken
approved these changes
Jan 27, 2022
The test case here was taken from #15308. The main bugfix here is to use `stream.node` rather than just `stream` when attempting to get node properties from a stream. There were some extra properties added to the streams back in #15167, but this change reverts that and instread fixes up the streams returned by NODERAWFS such that they have the correct/expected fields.
sbc100
force-pushed
the
fix_nodefs_readdir
branch
from
d698e09 to
bf21992
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test case here was taken from #15308.
The main bugfix here is to use
stream.noderather than juststreamwhen attempting to get node properties from a stream. There were some
extra properties added to the streams back in #15167, but this change
reverts that and instread fixes up the streams returned by NODERAWFS
such that they have the correct/expected fields.