Fix wasm2s (SAFE_HEAP) test suite #15944
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
safe_heap
branch
2 times, most recently
from
b45172c to
d7c4935
Compare
sbc100
force-pushed
the
safe_heap
branch
2 times, most recently
from
169d8d6 to
de1191e
Compare
kripken
reviewed
Jan 10, 2022
There was a problem hiding this comment.
Breakage risk seems low as SAFE_HEAP is a rare mode, I'd guess, so this seems reasonable.
OTOH if this is specific to minimal runtime, maybe we should only change things there? I am just wondering if there are cases where someone has a good reason for SAFE_HEAP without the extra logic of assertions. Like maybe a bug appears only when assertions are disabled.
This change fixes all the failing tests in the wasm2s suite. Depends on WebAssembly/binaryen#4439.
kripken
approved these changes
Jan 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes all but 1 failing tests in the wasm2s suite. The final fix is in #15945.
My goal here is to enable this test suite on the emscripten-releases waterfall:
https://chromium-review.googlesource.com/c/emscripten-releases/+/3378856