Avoid using EM_ASM in sbrk.c #15945
Merged
Avoid using EM_ASM in sbrk.c #15945
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I ran into some issues with the use of EM_ASM here related to SAFE_HEAP. Its probably not a great idea to use EM_ASM in such a low level context.
kripken
reviewed
Jan 10, 2022
We tend not to use EM_ASM or EM_JS in our low level libraries... I tend to think thats a good thing. We could consider making more use of EM_JS in general, but I think that is outside the scope of this change. |
sbc100
added a commit
that referenced
this pull request
Jan 11, 2022
This change fixes all the failing tests in the wasm2s suite. The final fix is in #15945. Depends on WebAssembly/binaryen#4439.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into some issues with the use of EM_ASM here related to SAFE_HEAP.
Its probably not a great idea to use EM_ASM in such a low level context.