jsifier: Rename libraryFunction -> librarySymbols #17411
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
rename_libraryFunctions
branch
from
abadc89 to
e4b8558
Compare
xbcnn
pushed a commit
to xbcnn/emscripten
that referenced
this pull request
Jul 22, 2022
aheejin
added a commit
to aheejin/emscripten
that referenced
this pull request
Oct 3, 2022
It looks they are not necessary anymore since emscripten-core#17411. `__asyncify_state__import` and `__asyncify_data__import` were added after that when emscripten-core#15893 landed, and `__c_longjmp_import` was a typo in the first place (there are only one `_` instead of two `_`s before `import`) so it was likely not detected when other uses were removed.
aheejin
added a commit
that referenced
this pull request
Oct 4, 2022
It looks they are not necessary anymore since #17411. `__asyncify_state__import` and `__asyncify_data__import` were added after that when #15893 landed, and `__c_longjmp_import` was a typo in the first place (there is only one `_` instead of two `_`s before `import`) so it was likely not detected when other uses were removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, include all library symbols, not just functions, in the list which allows things
like wasm globals, numbers, and other elements to be linked into native code
and/or exported via
DEFAULT_LIBRARY_FUNCS_TO_INCLUDE.This allows us to remove the special
__importdecorator.