Skip to content

Remove remaining uses of __import decorator #17975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 4, 2022

Conversation

aheejin
Copy link
Member

@aheejin aheejin commented Oct 3, 2022

It looks they are not necessary anymore since #17411. __asyncify_state__import and __asyncify_data__import were added after that when #15893 landed, and __c_longjmp_import was a typo in the first place (there is only one _ instead of two _s before import) so it was likely not detected when other uses were removed.

It looks they are not necessary anymore since emscripten-core#17411.
`__asyncify_state__import` and `__asyncify_data__import` were added
after that when emscripten-core#15893 landed, and `__c_longjmp_import` was a typo in
the first place (there are only one `_` instead of two `_`s before
`import`) so it was likely not detected when other uses were removed.
@aheejin aheejin requested a review from sbc100 October 3, 2022 20:23
Copy link
Collaborator

@sbc100 sbc100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@aheejin aheejin merged commit aa127f8 into emscripten-core:main Oct 4, 2022
@aheejin aheejin deleted the remove_import branch October 4, 2022 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants