Correct API ROOT to enable parametered urls #3190
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hiya - this needs more detail - could you give an example case please? |
|
Sure, It didn't work as the kwargs (containing the "my_parameter" information) were not provided to the reverse method. |
| @@ -291,6 +291,7 @@ def get(self, request, *args, **kwargs): | |||
| try: | |||
| ret[key] = reverse( | |||
| url_name, | |||
| kwargs=kwargs, | |||
There was a problem hiding this comment.
Presumably if we're doing this then we'd want to include args too?
There was a problem hiding this comment.
Yes we should, I just didn't have any use case of not named parameters (as I'm not used to using it).
|
Similar: #2790 |
|
Seems reasonable. Thanks! |
tomchristie
added a commit
that referenced
this pull request
Jul 30, 2015
Correct API ROOT to enable parametered urls
|
Thanks a lot for your work! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all,
This small modification is needed to be able to completely build parametered urls in the API Root.