Skip to content

Correct API ROOT to enable parametered urls #3190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 30, 2015
Merged

Correct API ROOT to enable parametered urls #3190

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2109f55
Correct API ROOT to enable parametered urls
Jul 28, 2015
d2ae7d4
Add args to the function call for unnamed parameters
Jul 29, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions rest_framework/routers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,6 +291,8 @@ def get(self, request, *args, **kwargs):
try:
ret[key] = reverse(
url_name,
args=args,
kwargs=kwargs,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Presumably if we're doing this then we'd want to include args too?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes we should, I just didn't have any use case of not named parameters (as I'm not used to using it).

request=request,
format=kwargs.get('format', None)
)
Expand Down