Add couple of tests for compat module #4845
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomchristie
approved these changes
Jan 24, 2017
kevin-brown
reviewed
Jan 24, 2017
| seconds = 1 | ||
| microseconds = 100 | ||
| timedelta = MockTimedelta() | ||
| expected = (timedelta.days * 86400.0) + float(timedelta.seconds) + (timedelta.microseconds / 1000000.0) |
There was a problem hiding this comment.
Is there any reason why we chose to calculate the expected value in the test instead of working from a known-good value for how many seconds there are?
kevin-brown
reviewed
Jan 24, 2017
| compat.django.VERSION = (1, 10) | ||
| assert compat.get_remote_field(MockField(), default='default_value') == 'example_remote_field' | ||
| assert compat.get_remote_field(object(), default='default_value') == 'default_value' | ||
| compat.django.VERSION = original_django_version |
There was a problem hiding this comment.
This won't reset the Django version if this test fails, because an AssertionError will be raised before it gets to this point.
There was a problem hiding this comment.
Good point - lazy review on my part.
vpistis
added a commit
to vpistis/django-rest-framework
that referenced
this pull request
Feb 6, 2017
* master: (95 commits) Add max_length and min_length arguments for ListField (encode#4877) Update sponsors on README to include rollbar (encode#4876) Added Rollbar to premium sponsors fixed url checker ':' to 'http' (encode#4678) Fixed `dedent` for tab indent. Add test for pagination when limit not set Fixed Django 2.0 compatibility due to `django.conf.urls.include` parameters change. (encode#4866) Add remaining tests for generics (encode#4865) Removed unnecessary importlib wrapper. Updated Support section and added funding email (encode#4860) Git add remaining tests for BaseSerializer (encode#4857) Update machinalis links Updated Machinalis links (encode#4856) Add remaining tests for metadata (encode#4855) Fixed encode#4574 -- Removed multi-table inheritance auto created PK from serialize. (encode#4852) Add couple of tests for filters (encode#4849) Refactor according to comments in PR (encode#4848) Add couple of tests for compat module (encode#4845) Direct readers to info on how to add viewset docs (encode#4844) Fixed test_one_to_one_with_inheritance. Added required on_delete attribute to OneToOneField field. (encode#4838) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.