Skip to content

Fixed Django 2.0 compatibility due to django.conf.urls.include parameters change. #4866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 30, 2017

Conversation

felixxm
Copy link
Contributor

@felixxm felixxm commented Jan 30, 2017

Fixed Django 2.0 compatibility due to django.conf.urls.include parameters change (see Django documentation 1.8, 2.0).

==================================== ERRORS ====================================
____________________ ERROR collecting tests/test_routers.py ____________________
tests/test_routers.py:84: in <module>
    url(r'^namespaced/', include(namespaced_router.urls, namespace='example')),
/django/conf/urls/__init__.py:44: in include
    'Specifying a namespace in django.conf.urls.include() without '
E   django.core.exceptions.ImproperlyConfigured: Specifying a namespace in
django.conf.urls.include() without providing an app_name is not supported.
Set the app_name attribute in the included module, or pass a 2-tuple containing
the list of patterns and app_name instead.
__________________ ERROR collecting tests/test_versioning.py ___________________
tests/test_versioning.py:166: in <module>
    class TestURLReversing(URLPatternsTestCase):
tests/test_versioning.py:173: in TestURLReversing
    url(r'^v1/', include(included, namespace='v1')),
/django/conf/urls/__init__.py:44: in include
    'Specifying a namespace in django.conf.urls.include() without '
E   django.core.exceptions.ImproperlyConfigured: Specifying a namespace in
django.conf.urls.include() without providing an app_name is not supported.
Set the app_name attribute in the included module, or pass a 2-tuple containing
the list of patterns and app_name instead.

@felixxm
Copy link
Contributor Author

felixxm commented Jan 30, 2017

All remaining errors are related with django-guardian. They already fixed them (see 276da317), we need to wait for v.1.4.7 version.

@tomchristie
Copy link
Member

Great stuff!

@tomchristie tomchristie merged commit 3001b56 into encode:master Jan 30, 2017
@tomchristie tomchristie added this to the 3.5.4 Release milestone Jan 30, 2017
@felixxm felixxm deleted the issue-include-change branch January 30, 2017 16:37
vpistis added a commit to vpistis/django-rest-framework that referenced this pull request Feb 6, 2017
* master: (95 commits)
  Add max_length and min_length arguments for ListField (encode#4877)
  Update sponsors on README to include rollbar (encode#4876)
  Added Rollbar to premium sponsors
  fixed url checker ':' to 'http' (encode#4678)
  Fixed `dedent` for tab indent.
  Add test for pagination when limit not set
  Fixed Django 2.0 compatibility due to `django.conf.urls.include` parameters change. (encode#4866)
  Add remaining tests for generics (encode#4865)
  Removed unnecessary importlib wrapper.
  Updated Support section and added funding email (encode#4860)
  Git add remaining tests for BaseSerializer (encode#4857)
  Update machinalis links
  Updated Machinalis links (encode#4856)
  Add remaining tests for metadata (encode#4855)
  Fixed encode#4574 -- Removed multi-table inheritance auto created PK from serialize. (encode#4852)
  Add couple of tests for filters (encode#4849)
  Refactor according to comments in PR (encode#4848)
  Add couple of tests for compat module (encode#4845)
  Direct readers to info on how to add viewset docs (encode#4844)
  Fixed test_one_to_one_with_inheritance. Added required on_delete attribute to OneToOneField field. (encode#4838)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants