Skip to content

Undo layout changes from #515 #523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 13, 2017

Conversation

samtstern
Copy link
Contributor

No description provided.

Change-Id: I4e5d3ed02710a2f3681816be8e7df122f977fa65
@samtstern
Copy link
Contributor Author

Fixes #521.

@puf or @SUPERCILEX PTAL. This will have to become v1.1.1 since we broke people who don't use a logo (which means we broke the default).

@samtstern
Copy link
Contributor Author

First build errored out due a Travis issue, but it passed on restart:
https://travis-ci.org/samtstern/FirebaseUI-Android

@SUPERCILEX
Copy link
Collaborator

@samtstern LGTM. Would you be ok with me trying to rewrite the auth picker layout using ConstraintLayout? It would let us use constraint biases meaning we don't need hard dp values making the layout more flexible. If not, I would still like to submit a PR making horizontal layouts usable by moving the buttons to the right of the logo.

PS: if you're cool with ConstraintLayout, I would like to slowly convert our codebase to use it thus minimizing nesting and improving performance. The original plan was to submit one massive PR converting everything to ConstraintLayout, but I don't think that's going to happen. Instead, we can go through it one layout at a time.

@samtstern
Copy link
Contributor Author

@SUPERCILEX I do think in general ConstraintLayout is a great solution to this problem. However in the interest of un-breaking people quickly I think this simple revert as 1.1.1 is the right thing to do (surprisingly we never got complaints in the past about the layout).

How do you feel about targeting fluid layouts for 1.2.0?

@SUPERCILEX
Copy link
Collaborator

@samtstern no no, I totally agree with you. Sorry for not making this clearer: I'm expecting the ConstraintLayout transition to be slow and drawn out so we can ensure quality and not mess stuff up. This PR should definitely be merged into the 1.1.1 release and the ConstraintLayout stuff my even be spread out into the 1.3.0 release depending on how quickly you want to get 1.2.0 out.

PS: I believe #375 is a complaint about landscape layout.

@samtstern
Copy link
Contributor Author

@SUPERCILEX 👍

@samtstern samtstern merged commit 5490994 into firebase:master Jan 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants