Translations for auth #771
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ashwinraghav
commented
Jun 21, 2017
ashwinraghav
commented
- This change imports translations for firebase UI auth. Issues related to formatting (particularly for RTL languages) are to be expected. Fixes are welcome 👍
- Once we see some stability with the UI for translations, we could roll forward with publishing version 11.0.1.
Change-Id: Iee013581f6d1e7e7387c06ce3895c378f03a6b23
|
I'm gonna write some scripts to clean up these translations. |
Change-Id: Iaea384e3957470181d802a702d7f1a6feffea124
Change-Id: Ibeec6996cfc24d59366cfcb94297ce9007c73b9f
|
The only thing we're missing now is a translation for |
Change-Id: I2495679d27e4342946ad1744004639dc1bf43cb3
Change-Id: Ie45aa4e35e5078e8f6b08c1015f4b075c54f0f2f
Merged
Change-Id: I1ffcc0168c0ab29bbfefaaf746ead0aa4da648e0
… into translations Change-Id: I6b3c7b6c30e4fb699eabd4e1cd019edf84046b4a
Change-Id: I530e90a032b58211ba6ee85595f7c43a0f499bdb
Change-Id: Ibb8a5b10395127e428ce21b9cd27fbd8535ed9a2
|
@ashwinraghav did you have a reason for disabling the |
Change-Id: I2a91ae6a2a8d8950713aafa2391c16e4afc1fbcd
mswolters
reviewed
Jul 13, 2017
| <string name="resend_code" translation_description="Link text to resend verification sms">Code opnieuw verzenden</string> | ||
| <string name="verify_phone_number" translation_description="Button text to submit confirmation code and complete phone verification">Telefoonnummer verifiëren</string> | ||
| <string name="continue_phone_login" translation_description="Button text to submit phone number and send sms">Doorgaan</string> | ||
| <string name="sms_terms_of_service" translation_description="Fine print warning displayed below Verify Phone Number button">Als u op \'%1$s\', ontvangt u mogelijk een sms. Er kunnen sms- en datakosten in rekening worden gebracht.</string> |
There was a problem hiding this comment.
A verb is missing in this sentence. It should be Als u op \'%1$s\' tikt, ontvangt u mogelijk een sms. Er kunnen sms- en datakosten in rekening worden gebracht.
There was a problem hiding this comment.
Thanks for this! I submitted this back as a "suggestion" in our system.
Change-Id: I82c8ecd1da9bc1dabc60af948f14b44fd9a85426
Change-Id: I1d134d5d2c38d5e8b94d0ae33629dc1d23a88454
Change-Id: I5b94ff678ea3e9073024650dc6f9e14a5cfd45bb
Change-Id: I442e557cc99071685c6eee33ce85be1ee924d8e9
Change-Id: Ib5c391e9bb9162ba64419adb42b8fba219f6c7d7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.