Skip to content

Commit 7533855

Browse files
authored
Re-add tools:targetApi to firebase-common AndroidManifest. (#749)
This attr had to be removed in #728 because a bug in the tooling that has been fixed now.
1 parent be0146a commit 7533855

File tree

2 files changed

+3
-12
lines changed

2 files changed

+3
-12
lines changed

firebase-common/lint-baseline.xml

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,4 @@
11
<?xml version="1.0" encoding="UTF-8"?>
22
<issues format="5" by="lint 3.4.1" client="gradle" variant="all" version="3.4.1">
3-
<!-- TODO: remove when bazel support tools:targetApi -->
4-
<issue
5-
id="UnusedAttribute"
6-
message="Attribute `directBootAware` is only used in API level 24 and higher (current min is 14)"
7-
errorLine1=" android:directBootAware=&quot;true&quot; android:exported=&quot;false&quot;/>"
8-
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
9-
<location
10-
file="src/main/AndroidManifest.xml"
11-
line="11"
12-
column="9"/>
13-
</issue>
143

154
</issues>

firebase-common/src/main/AndroidManifest.xml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,15 @@
11
<?xml version="1.0" encoding="utf-8"?>
22
<manifest
33
xmlns:android="http://schemas.android.com/apk/res/android"
4+
xmlns:tools="http://schemas.android.com/tools"
45
package="com.google.firebase">
56
<!--Although the *SdkVersion is captured in gradle build files, this is required for non gradle builds-->
67
<!--<uses-sdk android:minSdkVersion="14"/>-->
78
<application>
89

910
<service android:name="com.google.firebase.components.ComponentDiscoveryService"
10-
android:directBootAware="true" android:exported="false"/>
11+
android:directBootAware="true" android:exported="false"
12+
tools:targetApi="n" />
1113

1214
<provider
1315
android:name="com.google.firebase.provider.FirebaseInitProvider"

0 commit comments

Comments
 (0)