Skip to content

Whitelist lint warning for missing tools:targetApi attr. #728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 22, 2019

Conversation

rlazo
Copy link
Collaborator

@rlazo rlazo commented Aug 22, 2019

No description provided.

@googlebot googlebot added the cla: yes Override cla label Aug 22, 2019
@@ -0,0 +1,15 @@
<?xml version="1.0" encoding="UTF-8"?>
<issues format="5" by="lint 3.4.1" client="gradle" variant="all" version="3.4.1">

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls add a todo here to undo this once bazel supports the attribute

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@rlazo rlazo merged commit 6aa59b9 into master Aug 22, 2019
@rlazo rlazo deleted the rl.targetapi-whitelisting branch August 22, 2019 17:18
rlazo added a commit that referenced this pull request Aug 29, 2019
This attr had to be removed in
#728 because a
bug in the tooling that has been fixed now.
rlazo added a commit that referenced this pull request Aug 30, 2019
This attr had to be removed in
#728 because a
bug in the tooling that has been fixed now.
@firebase firebase locked and limited conversation to collaborators Oct 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes Override cla size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants